Merge lp:~fboucault/camera-app/bottom_edge_test_conditional into lp:camera-app

Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 543
Merged at revision: 543
Proposed branch: lp:~fboucault/camera-app/bottom_edge_test_conditional
Merge into: lp:camera-app
Diff against target: 15 lines (+5/-0)
1 file modified
tests/unittests/tst_BottomEdgeIndicators.qml (+5/-0)
To merge this branch: bzr merge lp:~fboucault/camera-app/bottom_edge_test_conditional
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+254400@code.launchpad.net

Commit message

Unit tests: make tst_BottomEdgeIndicators::test_options conditional on the presence of Qt5.4

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/unittests/tst_BottomEdgeIndicators.qml'
--- tests/unittests/tst_BottomEdgeIndicators.qml 2015-03-11 20:03:21 +0000
+++ tests/unittests/tst_BottomEdgeIndicators.qml 2015-03-27 14:53:23 +0000
@@ -103,6 +103,11 @@
103 }103 }
104104
105 function test_options(data) {105 function test_options(data) {
106 try {
107 Qt.createQmlObject("import QtQuick 2.4; Item {}", indicators);
108 } catch (e) {
109 skip("This test requires Qt 5.4");
110 }
106 indicators.options = data.options;111 indicators.options = data.options;
107 var emptyIndicatorsHint = findChild(indicators, "emptyIndicatorsHint");112 var emptyIndicatorsHint = findChild(indicators, "emptyIndicatorsHint");
108 var indicatorsRow = findChild(indicators, "indicatorsRow");113 var indicatorsRow = findChild(indicators, "indicatorsRow");

Subscribers

People subscribed via source and target branches