Merge lp:~faure/libdbusmenu-qt/fix_qt5_build into lp:libdbusmenu-qt

Proposed by David Faure
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 239
Merged at revision: 239
Proposed branch: lp:~faure/libdbusmenu-qt/fix_qt5_build
Merge into: lp:libdbusmenu-qt
Diff against target: 51 lines (+9/-6)
2 files modified
CMakeLists.txt (+8/-5)
src/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~faure/libdbusmenu-qt/fix_qt5_build
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Review via email: mp+145274@code.launchpad.net

Description of the change

Qt5 build: Port to ECM 0.0.4, and use GNUInstallDirs to autodetect "lib64".

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

I think the ECM dependency is a bit weird given that there hasn't been a release but the dependency is not new, so hardly anything I can push agaist.

Besides that It makes sense.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2012-05-21 20:16:56 +0000
+++ CMakeLists.txt 2013-01-28 23:23:22 +0000
@@ -48,26 +48,29 @@
48if (Qt5Widgets_FOUND)48if (Qt5Widgets_FOUND)
49 find_package(Qt5DBus REQUIRED)49 find_package(Qt5DBus REQUIRED)
50 include_directories(${Qt5Widgets_INCLUDE_DIRS} ${Qt5DBus_INCLUDE_DIRS})50 include_directories(${Qt5Widgets_INCLUDE_DIRS} ${Qt5DBus_INCLUDE_DIRS})
51 find_package(extra-cmake-modules 0.0.2 REQUIRED)51 find_package(ECM 0.0.4 REQUIRED)
52 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${EXTRA_CMAKE_MODULES_MODULE_PATH})52 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
53 find_package(Qt5Transitional REQUIRED Core)53 find_package(Qt5Transitional REQUIRED Core)
54 set(CMAKE_AUTOMOC ON)54 set(CMAKE_AUTOMOC ON)
55 set(CMAKE_AUTOMOC_RELAXED_MODE ON)55 set(CMAKE_AUTOMOC_RELAXED_MODE ON)
56 include(GNUInstallDirs)
57 set(LIB_DESTINATION "${CMAKE_INSTALL_LIBDIR}")
56else()58else()
57find_package(Qt4 REQUIRED)59 find_package(Qt4 REQUIRED)
58include_directories(60 include_directories(
59 ${QT_INCLUDE_DIR}61 ${QT_INCLUDE_DIR}
60 ${QT_QTCORE_INCLUDE_DIR}62 ${QT_QTCORE_INCLUDE_DIR}
61 ${QT_QTDBUS_INCLUDE_DIR}63 ${QT_QTDBUS_INCLUDE_DIR}
62 ${QT_QTGUI_INCLUDE_DIR}64 ${QT_QTGUI_INCLUDE_DIR}
63 )65 )
66 set(LIB_DESTINATION "lib${LIB_SUFFIX}" CACHE STRING "Library directory name" FORCE)
64endif()67endif()
6568
6669
67configure_file(dbusmenu-qt.pc.in ${CMAKE_BINARY_DIR}/dbusmenu-qt.pc @ONLY)70configure_file(dbusmenu-qt.pc.in ${CMAKE_BINARY_DIR}/dbusmenu-qt.pc @ONLY)
6871
69install(FILES ${CMAKE_BINARY_DIR}/dbusmenu-qt.pc72install(FILES ${CMAKE_BINARY_DIR}/dbusmenu-qt.pc
70 DESTINATION lib${LIB_SUFFIX}/pkgconfig73 DESTINATION ${LIB_DESTINATION}/pkgconfig
71 )74 )
7275
73add_subdirectory(src)76add_subdirectory(src)
7477
=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt 2012-05-21 20:16:56 +0000
+++ src/CMakeLists.txt 2013-01-28 23:23:22 +0000
@@ -75,7 +75,7 @@
75 )75 )
7676
77install(TARGETS dbusmenu-qt77install(TARGETS dbusmenu-qt
78 LIBRARY DESTINATION lib${LIB_SUFFIX}78 LIBRARY DESTINATION ${LIB_DESTINATION}
79 RUNTIME DESTINATION bin)79 RUNTIME DESTINATION bin)
8080
81install(DIRECTORY .81install(DIRECTORY .

Subscribers

People subscribed via source and target branches

to all changes: