Code review comment for lp:~faubulous/inkscape/cmake-win32
Revision history for this message
| jazzynico (jazzynico) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Just tried it on Windows 7 with the win32 build env (32-bit devlibs and TDM-GCC-4.6). Some comments (note that I'm a cmake newbie):
1. CMake doesn't use GS_BIN when already set (in my mingwenv.bat). It instead tries to add /bin to GS_PATH. Note that some files (pdf2ps.bat) in GS_PATH/lib need to be in GS_BIN too so that related extensions work as expected.
2. Why did you define DEVLIBS_PATH and MINGW_PATH in configure.bat? They are already defined in mingwenv.bat (with some additional paths).
3. I used -G "MSYS Makefiles" to run cmake from the MSYS shell. Cmake worked fine, but then 'make' failed when linking to the libinkscape_base shared library.
4. Then I tried -G "MinGW Makefiles" from a Windows console. Same linking problem.
That said, it's a very interesting improvement (I never managed to use cmake with the win32 build env. before!). Thanks!