Merge ~falcojr/curtin:update-manager-in-docs into curtin:master

[James Falcon]

Replace references to old team manager with new team manager

Replace references to old team manager with new team manager

[Ryan Harper (raharper)]

Thanks for the Merge Proposal (MP). I failed to bring up how we land changes, so this is my fault.

1) Please move your Description into the 'Set Commit Message' box; the autolander here won't use the description and complains when it's set at landing time.

2) The format for the commit message is:

oneliner

Longer description here with details on what
changed. Including addition changes in the merge

 - I also updated the .gitignore file

LP: #NNNNNNN if this was fixing a bug

review: Needs Fixing

[James Falcon (falcojr)]

What is the purpose of the "Set Commit Message" box? Is it the text for a merge commit? If my other commits live on their own, what text would we want for an additional commit? I don't want them squashed.

As far as commit format, I saw that, but there's no LP, and no additional explanation needed for these commits, right? I would normally add more info, but these don't need any more explanation than the one-liners they are, correct?

[Ryan Harper (raharper)]

We do squash merge commits (for historic reasons that have to do with bazaar; which did squash merges, but kept the original commit history "hidden"). So the box is what's going into the commit history for this item.

w.r.t the format, yeah, no LP and single line commit is ok, just needs to be under 76 chars

[Chad Smith (chad.smith)]

James, thanks for the patch/fix. I think if you can drop your commit 5a0c88c and propose that as a separate branch with an explanation of the intent there, it'd be easier to digest since we try to avoid placing unrelated changes into a squashed commit.

review: Needs Fixing

[James Falcon (falcojr)]

Sure. Makes sense. Didn't really all branches got squashed when I pushed this.

[Chad Smith (chad.smith)]

Thanks for that James! LGTM!

review: Approve

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/171/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/171/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/171/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/171/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/171/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/172/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/172/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/172/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/172/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/172/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/173/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/173/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/173/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/173/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/173/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/174/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/174/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/174/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/174/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/174/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/175/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/175/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/175/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/175/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/175/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/176/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/176/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/176/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/176/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/176/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/177/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/177/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/177/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/177/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/177/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/178/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/178/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/178/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/178/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/178/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/179/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/179/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/179/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/179/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/179/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/180/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/180/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/180/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/180/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/180/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/181/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/181/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/181/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/181/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/181/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/182/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/182/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/182/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/182/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/182/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/183/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/183/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/183/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/183/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/183/

review: Needs Fixing (continuous-integration)

[Ryan Harper (raharper)]

py3-flake8 runtests: commands[0] | /jenkins/servers/server/workspace/curtin-autoland-test/nodes/metal-amd64/curtin/.tox/py3-flake8/bin/python -m flake8 curtin tests/
curtin/block/bcache.py:322:31: E741 ambiguous variable name 'l'
curtin/block/bcache.py:323:30: E741 ambiguous variable name 'l'
curtin/block/lvm.py:26:40: E741 ambiguous variable name 'l'
curtin/block/__init__.py:1319:17: E741 ambiguous variable name 'l'
tests/unittests/test_block_dasd.py:20:21: E741 ambiguous variable name 'l'
tests/unittests/test_apt_source.py:961:26: E741 ambiguous variable name 'l'
tests/vmtests/test_fs_battery.py:168:27: E741 ambiguous variable name 'l'
tests/vmtests/test_network.py:111:28: E741 ambiguous variable name 'l'

is what autoland is showing.

@Chad we need to manually queue James's branch in CI, or add him to the correct lp group to have automatic CI.

I cannot reproduce the tox failure locally so something is different for autolander tox =(

[Paride Legovini (paride)]

The autoland job just runs a plain 'tox' on the source tree [1], and I can reproduce that problem locally on my Groovy system.

It's annoying when the autolander job runs in this kind of loop. One easy way to prevent it would be to have the autolander job to set the MP back to "Needs review" on failure. What do you think?

It would be nice to have it set the MP back to "Needs review" after e.g. 3 failures. I was thinking of doing this using the Jenkins "unstable" state, but this is not possible as the status of job is not per-MP.

[1] https://github.com/canonical/server-jenkins-jobs/blob/master/curtin/jobs-ci.yaml#L187

[Ryan Harper (raharper)]

> The autoland job just runs a plain 'tox' on the source tree [1], and I
> can reproduce that problem locally on my Groovy system.

Looks like tox.ini needs a tip-flake8 so we can reproduce this elsewhere.

>
> It's annoying when the autolander job runs in this kind of loop. One
> easy way to prevent it would be to have the autolander job to set the
> MP back to "Needs review" on failure. What do you think?

+1 on moving back to needs review.

> It would be nice to have it set the MP back to "Needs review" after e.g. 3
> failures. I was thinking of doing this using the Jenkins "unstable" state, but
> this is not possible as the status of job is not per-MP.
>
> [1] https://github.com/canonical/server-jenkins-jobs/blob/master/curtin/jobs-ci.yaml#L187

So can it be done in our jobs or not?

[Ryan Harper (raharper)]

https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383810

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:ae20073ecc964eb08e96ac625b441065d4ae56ad
https://jenkins.ubuntu.com/server/job/curtin-ci/84/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/84/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/84/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/84/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/84/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/84//rebuild

review: Needs Fixing (continuous-integration)

[Chad Smith (chad.smith)]

I think this should land now that paride's branch is approved (once it merges)
 https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:ae20073ecc964eb08e96ac625b441065d4ae56ad
https://jenkins.ubuntu.com/server/job/curtin-ci/105/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/105/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/105/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/105/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/105/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/105//rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

review: Approve (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/186/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/186/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/186/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/187/
Executed test runs:
    ABORTED: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/187/
    ABORTED: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-arm64/187/
    ABORTED: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-ppc64el/187/
    ABORTED: https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-s390x/187/

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

review: Approve (continuous-integration)

diff --git a/HACKING.rst b/HACKING.rst
index 58adf76..f2b618d 100644
--- a/HACKING.rst
+++ b/HACKING.rst
@@ -15,11 +15,11 @@ Do these things once
   be listed in the `contributor-agreement-canonical`_ group.  Unfortunately
   there is no easy way to check if an organization or company you are doing
   work for has signed.  If you are unsure or have questions, email
-  `Josh Powers <mailto:[e-mail]>` or ping powersj in
+  `Rick Harding <mailto:[e-mail]>` or ping rick_h in
   ``#curtin`` channel via Freenode IRC.
 
   When prompted for 'Project contact' or 'Canonical Project Manager' enter
-  'Josh Powers'.
+  'Rick Harding'.
 
 * Configure git with your email and name for commit messages.