Code review comment for lp:~faenil/ubuntu-ui-toolkit/oldcaption_alignment_fix

Revision history for this message
Tim Peeters (tpeeters) wrote :

I'm not sure this is the place where the bug should be fixed. I commented about that in the bug report.

Please check out the QML coding conventions on http://doc.qt.io/qt-4.8/qml-coding-conventions.html

26 + anchors.verticalCenter: parent.verticalCenter
27 + anchors.left: parent.left
28 + anchors.right: parent.right
29 + anchors.leftMargin: __contentMargin
30 + anchors.rightMargin: __contentMargin

These should be grouped in
anchors {
...
}

review: Needs Fixing

« Back to merge proposal