Ok, code looks nice, docs as well, design change should have been written in the description so reviewer knows what additional change is added beside the fix. Next time please do a separate MR for that. It doesn't belong to this fix logically.
« Back to merge proposal
Ok, code looks nice, docs as well, design change should have been written in the description so reviewer knows what additional change is added beside the fix. Next time please do a separate MR for that. It doesn't belong to this fix logically.