Merge lp:~facundo/ubuntuone-storage-protocol/discriminate_auth_error into lp:ubuntuone-storage-protocol

[Facundo Batista]

In case of receiving an ERROR, we raise StorageRequestError with what we received.

[Facundo Batista (facundo)]

In case of receiving an ERROR, we raise StorageRequestError with what we received.

Before, it was masked/confused in a StorageProtocolError.

[John Lenton (chipaca)]

Awesome.

review: Approve

[dobey (dobey)]

review: Approve

=== modified file 'ubuntuone/storageprotocol/client.py'
--- ubuntuone/storageprotocol/client.py	2009-09-09 18:51:28 +0000
+++ ubuntuone/storageprotocol/client.py	2009-10-16 17:05:18 +0000
@@ -1041,12 +1041,8 @@
         if message.type == protocol_pb2.Message.AUTH_AUTHENTICATED:
             self.done()
         elif message.type == protocol_pb2.Message.ERROR:
-            if message.error.type == protocol_pb2.Error.AUTHENTICATION_FAILED:
-                self.error(request.StorageProtocolError(
-                        "Authentication Failed"))
-            else:
-                self.error(request.StorageProtocolError(
-                        "Authentication Error:"+str(message)))
+            # as the error travels with the exception, we send all here
+            self.error(request.StorageRequestError(self, message))
         else:
             self.error(request.StorageProtocolError(
                         "Authentication Error:"+str(message)))