Code review comment for lp:~facundo/ubuntuone-client/stable--long-partial-filenames

Revision history for this message
John O'Brien (jdobrien) wrote :

Looks good...

Should we worry about filename = filename[:-10*trim] resulting in an index out of range if it evaluates to longer than the filename? I guess it's an internal function so perhaps not.

review: Approve

« Back to merge proposal