Ubuntu One Client

Merge lp:~facundo/ubuntuone-client/check_path_with_repr into lp:ubuntuone-client

  1. check_path_with_repr
  2. Merge into trunk
Proposed by Facundo Batista
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1124
Merged at revision: 1125
Proposed branch: lp:~facundo/ubuntuone-client/check_path_with_repr
Merge into: lp:ubuntuone-client
Diff against target: 64 lines (+7/-7)
1 file modified
tests/syncdaemon/test_sync.py (+7/-7)
To merge this branch: bzr merge lp:~facundo/ubuntuone-client/check_path_with_repr
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+73796@code.launchpad.net

Commit message

Check paths with repr in sync tests (LP: #839505).

Description of the change

Check paths with repr in sync tests.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/syncdaemon/test_sync.py'
--- tests/syncdaemon/test_sync.py 2011-09-01 19:50:22 +0000
+++ tests/syncdaemon/test_sync.py 2011-09-02 12:29:01 +0000
@@ -742,7 +742,7 @@
742 self.sync.handle_FS_FILE_CREATE(somepath)742 self.sync.handle_FS_FILE_CREATE(somepath)
743 self.assertFalse(called)743 self.assertFalse(called)
744 should_logged = ("FS_FILE_CREATE", "discarded",744 should_logged = ("FS_FILE_CREATE", "discarded",
745 "volume not subscribed", somepath)745 "volume not subscribed", repr(somepath))
746 self.assertTrue(self.handler.check_debug(*should_logged))746 self.assertTrue(self.handler.check_debug(*should_logged))
747747
748 @defer.inlineCallbacks748 @defer.inlineCallbacks
@@ -760,7 +760,7 @@
760 self.sync.handle_FS_DIR_CREATE(somepath)760 self.sync.handle_FS_DIR_CREATE(somepath)
761 self.assertFalse(called)761 self.assertFalse(called)
762 should_logged = ("FS_DIR_CREATE", "discarded",762 should_logged = ("FS_DIR_CREATE", "discarded",
763 "volume not subscribed", somepath)763 "volume not subscribed", repr(somepath))
764 self.assertTrue(self.handler.check_debug(*should_logged))764 self.assertTrue(self.handler.check_debug(*should_logged))
765765
766 @defer.inlineCallbacks766 @defer.inlineCallbacks
@@ -779,7 +779,7 @@
779 self.sync.handle_FS_FILE_DELETE(somepath)779 self.sync.handle_FS_FILE_DELETE(somepath)
780 self.assertFalse(called)780 self.assertFalse(called)
781 should_logged = ("FS_FILE_DELETE", "discarded",781 should_logged = ("FS_FILE_DELETE", "discarded",
782 "volume not subscribed", somepath)782 "volume not subscribed", repr(somepath))
783 self.assertTrue(self.handler.check_debug(*should_logged))783 self.assertTrue(self.handler.check_debug(*should_logged))
784784
785 @defer.inlineCallbacks785 @defer.inlineCallbacks
@@ -798,7 +798,7 @@
798 self.sync.handle_FS_DIR_DELETE(somepath)798 self.sync.handle_FS_DIR_DELETE(somepath)
799 self.assertFalse(called)799 self.assertFalse(called)
800 should_logged = ("FS_DIR_DELETE", "discarded",800 should_logged = ("FS_DIR_DELETE", "discarded",
801 "volume not subscribed", somepath)801 "volume not subscribed", repr(somepath))
802 self.assertTrue(self.handler.check_debug(*should_logged))802 self.assertTrue(self.handler.check_debug(*should_logged))
803803
804 @defer.inlineCallbacks804 @defer.inlineCallbacks
@@ -817,7 +817,7 @@
817 self.sync.handle_FS_FILE_MOVE(somepath, 'otherpath')817 self.sync.handle_FS_FILE_MOVE(somepath, 'otherpath')
818 self.assertFalse(called)818 self.assertFalse(called)
819 should_logged = ("FS_FILE_MOVE", "discarded",819 should_logged = ("FS_FILE_MOVE", "discarded",
820 "volume not subscribed", somepath)820 "volume not subscribed", repr(somepath))
821 self.assertTrue(self.handler.check_debug(*should_logged))821 self.assertTrue(self.handler.check_debug(*should_logged))
822822
823 @defer.inlineCallbacks823 @defer.inlineCallbacks
@@ -836,7 +836,7 @@
836 self.sync.handle_FS_DIR_MOVE(somepath, 'otherpath')836 self.sync.handle_FS_DIR_MOVE(somepath, 'otherpath')
837 self.assertFalse(called)837 self.assertFalse(called)
838 should_logged = ("FS_DIR_MOVE", "discarded",838 should_logged = ("FS_DIR_MOVE", "discarded",
839 "volume not subscribed", somepath)839 "volume not subscribed", repr(somepath))
840 self.assertTrue(self.handler.check_debug(*should_logged))840 self.assertTrue(self.handler.check_debug(*should_logged))
841841
842 @defer.inlineCallbacks842 @defer.inlineCallbacks
@@ -855,7 +855,7 @@
855 self.sync.handle_FS_FILE_CLOSE_WRITE(somepath)855 self.sync.handle_FS_FILE_CLOSE_WRITE(somepath)
856 self.assertFalse(called)856 self.assertFalse(called)
857 should_logged = ("FS_FILE_CLOSE_WRITE", "discarded",857 should_logged = ("FS_FILE_CLOSE_WRITE", "discarded",
858 "volume not subscribed", somepath)858 "volume not subscribed", repr(somepath))
859 self.assertTrue(self.handler.check_debug(*should_logged))859 self.assertTrue(self.handler.check_debug(*should_logged))
860860
861861

Subscribers

People subscribed via source and target branches