Code review comment for lp:~facundo/ubuntu/maverick/magicicada/0.2-update

Revision history for this message
Stefano Rivera (stefanor) wrote :

> So, I don't understand Stefano why you're finding differences for it

It's because they come from different sources (there isn't a common ancestry). I'm not going to dig into it, but I do agree that this diff is actually rather small and I'm happy to merge it.

BTW, I see you have a test suite, in future it would be nice to run this during build.

Also, you have some lintian warnings:

I: magicicada: description-synopsis-might-not-be-phrased-properly
I: magicicada: extended-description-is-probably-too-short
W: magicicada: spelling-error-in-changelog unecessary unnecessary
I: magicicada: package-contains-empty-directory usr/share/omf/magicicada/

review: Approve

« Back to merge proposal