Merge lp:~facundo/magicicada-gui/support-two-new-ops into lp:magicicada-gui

Proposed by Facundo Batista
Status: Merged
Approved by: Natalia Bidart
Approved revision: 55
Merged at revision: 54
Proposed branch: lp:~facundo/magicicada-gui/support-two-new-ops
Merge into: lp:magicicada-gui
Diff against target: 48 lines (+26/-1)
2 files modified
magicicada/dbusiface.py (+2/-1)
magicicada/tests/test_dbusiface.py (+24/-0)
To merge this branch: bzr merge lp:~facundo/magicicada-gui/support-two-new-ops
Reviewer Review Type Date Requested Status
Natalia Bidart Approve
Review via email: mp+29074@code.launchpad.net

Description of the change

Support the ChangePublicAccess and AnswerShare operations.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Very nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'magicicada/dbusiface.py'
--- magicicada/dbusiface.py 2010-06-21 17:10:41 +0000
+++ magicicada/dbusiface.py 2010-07-02 11:47:22 +0000
@@ -228,7 +228,8 @@
228 def _parse_mq(self, data):228 def _parse_mq(self, data):
229 """Parse MetaQueue string to extract its data."""229 """Parse MetaQueue string to extract its data."""
230 if data in ('AccountInquiry', 'FreeSpaceInquiry', 'GetPublicFiles',230 if data in ('AccountInquiry', 'FreeSpaceInquiry', 'GetPublicFiles',
231 'ListShares', 'ListVolumes', 'Query'):231 'ListShares', 'ListVolumes', 'Query',
232 'ChangePublicAccess', 'AnswerShare'):
232 return QueueData(operation=data, path=None, node=None, share=None)233 return QueueData(operation=data, path=None, node=None, share=None)
233234
234 m = RE_OP_LISTDIR.match(data)235 m = RE_OP_LISTDIR.match(data)
235236
=== modified file 'magicicada/tests/test_dbusiface.py'
--- magicicada/tests/test_dbusiface.py 2010-06-20 19:57:53 +0000
+++ magicicada/tests/test_dbusiface.py 2010-07-02 11:47:22 +0000
@@ -478,6 +478,30 @@
478 self.assertEqual(data.share, 'a')478 self.assertEqual(data.share, 'a')
479 self.assertEqual(data.node, 'b')479 self.assertEqual(data.node, 'b')
480480
481 @defer.inlineCallbacks
482 def test_ChangePublicAccess(self):
483 """Test meta with ChangePublicAccess."""
484 cmd = 'ChangePublicAccess'
485 self.fake_sdt_response('waiting_metadata', [cmd])
486 rcv = yield self.dbus.get_meta_queue()
487 data = rcv[0]
488 self.assertEqual(data.operation, 'ChangePublicAccess')
489 self.assertEqual(data.path, None)
490 self.assertEqual(data.share, None)
491 self.assertEqual(data.node, None)
492
493 @defer.inlineCallbacks
494 def test_AnswerShare(self):
495 """Test meta with AnswerShare."""
496 cmd = 'AnswerShare'
497 self.fake_sdt_response('waiting_metadata', [cmd])
498 rcv = yield self.dbus.get_meta_queue()
499 data = rcv[0]
500 self.assertEqual(data.operation, 'AnswerShare')
501 self.assertEqual(data.path, None)
502 self.assertEqual(data.share, None)
503 self.assertEqual(data.node, None)
504
481505
482class TestDataProcessingFolders(SafeTests):506class TestDataProcessingFolders(SafeTests):
483 """Process Folders data before sending it to SyncDaemon."""507 """Process Folders data before sending it to SyncDaemon."""

Subscribers

People subscribed via source and target branches