Merge lp:~facundo/magicicada-gui/support-two-new-ops into lp:magicicada-gui

Proposed by Facundo Batista
Status: Merged
Approved by: Natalia Bidart
Approved revision: 55
Merged at revision: 54
Proposed branch: lp:~facundo/magicicada-gui/support-two-new-ops
Merge into: lp:magicicada-gui
Diff against target: 48 lines (+26/-1)
2 files modified
magicicada/dbusiface.py (+2/-1)
magicicada/tests/test_dbusiface.py (+24/-0)
To merge this branch: bzr merge lp:~facundo/magicicada-gui/support-two-new-ops
Reviewer Review Type Date Requested Status
Natalia Bidart Approve
Review via email: mp+29074@code.launchpad.net

Description of the change

Support the ChangePublicAccess and AnswerShare operations.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Very nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'magicicada/dbusiface.py'
2--- magicicada/dbusiface.py 2010-06-21 17:10:41 +0000
3+++ magicicada/dbusiface.py 2010-07-02 11:47:22 +0000
4@@ -228,7 +228,8 @@
5 def _parse_mq(self, data):
6 """Parse MetaQueue string to extract its data."""
7 if data in ('AccountInquiry', 'FreeSpaceInquiry', 'GetPublicFiles',
8- 'ListShares', 'ListVolumes', 'Query'):
9+ 'ListShares', 'ListVolumes', 'Query',
10+ 'ChangePublicAccess', 'AnswerShare'):
11 return QueueData(operation=data, path=None, node=None, share=None)
12
13 m = RE_OP_LISTDIR.match(data)
14
15=== modified file 'magicicada/tests/test_dbusiface.py'
16--- magicicada/tests/test_dbusiface.py 2010-06-20 19:57:53 +0000
17+++ magicicada/tests/test_dbusiface.py 2010-07-02 11:47:22 +0000
18@@ -478,6 +478,30 @@
19 self.assertEqual(data.share, 'a')
20 self.assertEqual(data.node, 'b')
21
22+ @defer.inlineCallbacks
23+ def test_ChangePublicAccess(self):
24+ """Test meta with ChangePublicAccess."""
25+ cmd = 'ChangePublicAccess'
26+ self.fake_sdt_response('waiting_metadata', [cmd])
27+ rcv = yield self.dbus.get_meta_queue()
28+ data = rcv[0]
29+ self.assertEqual(data.operation, 'ChangePublicAccess')
30+ self.assertEqual(data.path, None)
31+ self.assertEqual(data.share, None)
32+ self.assertEqual(data.node, None)
33+
34+ @defer.inlineCallbacks
35+ def test_AnswerShare(self):
36+ """Test meta with AnswerShare."""
37+ cmd = 'AnswerShare'
38+ self.fake_sdt_response('waiting_metadata', [cmd])
39+ rcv = yield self.dbus.get_meta_queue()
40+ data = rcv[0]
41+ self.assertEqual(data.operation, 'AnswerShare')
42+ self.assertEqual(data.path, None)
43+ self.assertEqual(data.share, None)
44+ self.assertEqual(data.node, None)
45+
46
47 class TestDataProcessingFolders(SafeTests):
48 """Process Folders data before sending it to SyncDaemon."""

Subscribers

People subscribed via source and target branches