Code review comment for lp:~facundo/magicicada-gui/simple-api

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Is there a typo here: """Tells the SyncDaemon that the user wants it to DISconnect.""" ?

When running nose, I get:

======================================================================
ERROR: Check that it polls mq until no more is needed.
----------------------------------------------------------------------
TimeoutError: <test_syncdaemon.MetaQueueChangedTests testMethod=test_mq_polling_untilfinish> (test_mq_polling_untilfinish) still running at 2.0 secs

======================================================================
ERROR: Check that it polls mq until no more is needed.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 778, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/home/nessita/projects/magicicada/review_simple-api/magicicada/tests/test_syncdaemon.py", line 365, in check
    self.assertEqual(len(calls), 3)
  File "/usr/lib/python2.6/dist-packages/twisted/trial/unittest.py", line 287, in failUnlessEqual
    % (msg, pformat(first), pformat(second)))
FailTest: not equal:
a = 2
b = 3

----------------------------------------------------------------------
Ran 70 tests in 3.033s

FAILED (errors=2)

review: Needs Fixing

« Back to merge proposal