Code review comment for lp:~facundo/magicicada-gui/show-md

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

2 more things are needed:

(a) Could you please return a python dictionary instead a dbus dictionary? I'd want to keep dbus out the GTK layer.

(b) If the path doesn't exist, we'd need a special value, not a string saying "Not a valid path". This way we can ease the future translations, and we can detect this special case in a proper way.

« Back to merge proposal