Code review comment for lp:~facundo/locolander/ns2df

Revision history for this message
Loco Lander (locolander) wrote :

l. 20: I'd use pip instead of pypi
l. 29: I'd split each dependency into it's own line to make better use of the underlying caching algorithm of docker
l. 29: use apt-get install -q -y to avoid apt-get asking questions interactively
l. 30: no longer needed, part of the base image (assume /var/cache/locolander exists and will be used as the pip cache)

« Back to merge proposal