Juju Charms Collection
tanuki-result-enum-worker package

Code review comment for lp:~facundo/charms/trusty/tanuki-result-enum-worker/add-nagios-support

  1. Trusty Tahr (14.04)
  2. add-nagios-support
  3. Merge into trunk
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

The spec change landed already, which means that I've spent about half a day trying to figure out why I can't get the spec to work... turns out it's because the charm doesn't support 'nagios_context' yet.

I could rollback the spec, or land this. I'm choosing to land this, since Celso's comment isn't serious, and can be done in a separate branch. I'll create a trello card, assign it to Facundo, and point to this comment.

review: Approve

« Back to merge proposal