Merge lp:~fabiozaramella/switchboard-plug-security-privacy/fix-usage-cleaning into lp:~elementary-apps/switchboard-plug-security-privacy/trunk

Proposed by Fabio Zaramella
Status: Merged
Approved by: Cody Garver
Approved revision: 167
Merged at revision: 166
Proposed branch: lp:~fabiozaramella/switchboard-plug-security-privacy/fix-usage-cleaning
Merge into: lp:~elementary-apps/switchboard-plug-security-privacy/trunk
Diff against target: 131 lines (+76/-11)
1 file modified
src/TrackPanel.vala (+76/-11)
To merge this branch: bzr merge lp:~fabiozaramella/switchboard-plug-security-privacy/fix-usage-cleaning
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+255716@code.launchpad.net

Commit message

Fix deletion of files with Gtk.RecentManager

Description of the change

Actually delete recent files with Gtk.RecentManager.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/TrackPanel.vala'
--- src/TrackPanel.vala 2014-12-02 21:20:07 +0000
+++ src/TrackPanel.vala 2015-04-09 17:09:43 +0000
@@ -21,6 +21,10 @@
21 */21 */
2222
23public class SecurityPrivacy.TrackPanel : Gtk.Grid {23public class SecurityPrivacy.TrackPanel : Gtk.Grid {
24
25 private Gtk.RecentManager recent;
26 private List<Gtk.RecentInfo> items;
27
24 private Gtk.Popover info_popover;28 private Gtk.Popover info_popover;
25 private Gtk.Popover remove_popover;29 private Gtk.Popover remove_popover;
26 private Dialogs.AppChooser app_chooser;30 private Dialogs.AppChooser app_chooser;
@@ -51,6 +55,7 @@
51 app_blacklist = new ApplicationBlacklist (blacklist);55 app_blacklist = new ApplicationBlacklist (blacklist);
52 path_blacklist = new PathBlacklist (blacklist);56 path_blacklist = new PathBlacklist (blacklist);
53 filetype_blacklist = new FileTypeBlacklist (blacklist);57 filetype_blacklist = new FileTypeBlacklist (blacklist);
58 recent = new Gtk.RecentManager ();
5459
55 var privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");60 var privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");
5661
@@ -153,37 +158,97 @@
153 clear_button.get_style_context ().add_class (Gtk.STYLE_CLASS_DESTRUCTIVE_ACTION);158 clear_button.get_style_context ().add_class (Gtk.STYLE_CLASS_DESTRUCTIVE_ACTION);
154 clear_button.clicked.connect (() => {159 clear_button.clicked.connect (() => {
155 Zeitgeist.TimeRange tr;160 Zeitgeist.TimeRange tr;
156 if (past_hour_radio.active = true) {161
162 if (past_hour_radio.active == true) {
157 int range = 360000;//60*60*1000;163 int range = 360000;//60*60*1000;
158 int64 end = Zeitgeist.Timestamp.from_now ();164 int64 end = Zeitgeist.Timestamp.from_now ();
159 int64 start = end - range;165 int64 start = end - range;
160 tr = new Zeitgeist.TimeRange (start, end);166 tr = new Zeitgeist.TimeRange (start, end);
161 delete_history.begin (tr);167 delete_history.begin (tr);
162 } else if (past_day_radio.active = true) {168
169 // Deletes files added in the last hour
170 if (recent.size > 0) {
171 items = recent.get_items ();
172
173 try {
174 foreach (var item in items) {
175 if (item.get_added () >= start/1000)
176 recent.remove_item (item.get_uri ());
177 }
178 } catch (Error err) {
179 critical (err.message);
180 }
181 }
182 } else if (past_day_radio.active == true) {
163 int range = 8640000;//24*60*60*1000;183 int range = 8640000;//24*60*60*1000;
164 int64 end = Zeitgeist.Timestamp.from_now ();184 int64 end = Zeitgeist.Timestamp.from_now ();
165 int64 start = end - range;185 int64 start = end - range;
166 tr = new Zeitgeist.TimeRange (start, end);186 tr = new Zeitgeist.TimeRange (start, end);
167 delete_history.begin (tr);187 delete_history.begin (tr);
168 } else if (past_week_radio.active = true) {188
189 // Deletes files added in the last day
190 if (recent.size > 0) {
191 items = recent.get_items ();
192
193 try {
194 foreach (var item in items) {
195 if (item.get_age () <= 1)
196 recent.remove_item (item.get_uri ());
197 }
198 } catch (Error err) {
199 critical (err.message);
200 }
201 }
202 } else if (past_week_radio.active == true) {
169 int range = 60480000;//7*24*60*60*1000;203 int range = 60480000;//7*24*60*60*1000;
170 int64 end = Zeitgeist.Timestamp.from_now ();204 int64 end = Zeitgeist.Timestamp.from_now ();
171 int64 start = end - range;205 int64 start = end - range;
172 tr = new Zeitgeist.TimeRange (start, end);206 tr = new Zeitgeist.TimeRange (start, end);
173 delete_history.begin (tr);207 delete_history.begin (tr);
174 } else if (from_radio.active = true) {208
209 // Deletes files added in the last week
210 if (recent.size > 0) {
211 items = recent.get_items ();
212
213 try {
214 foreach (var item in items) {
215 if (item.get_age () <= 7)
216 recent.remove_item (item.get_uri ());
217 }
218 } catch (Error err) {
219 critical (err.message);
220 }
221 }
222 } else if (from_radio.active == true) {
175 int64 start = from_datepicker.date.to_unix ()*1000;223 int64 start = from_datepicker.date.to_unix ()*1000;
176 int64 end = from_datepicker.date.to_unix ()*1000;224 int64 end = to_datepicker.date.to_unix ()*1000;
177 tr = new Zeitgeist.TimeRange (start, end);225 tr = new Zeitgeist.TimeRange (start, end);
178 delete_history.begin (tr);226 delete_history.begin (tr);
179 } else if (all_time_radio.active = true) {227
228 // Deletes files added during the given period
229 if (recent.size > 0) {
230 items = recent.get_items ();
231
232 try {
233 foreach (var item in items) {
234 if (item.get_added () >= start/1000 && item.get_added () <= end/1000)
235 recent.remove_item (item.get_uri ());
236 }
237 } catch (Error err) {
238 critical (err.message);
239 }
240 }
241 } else if (all_time_radio.active == true) {
180 tr = new Zeitgeist.TimeRange.anytime ();242 tr = new Zeitgeist.TimeRange.anytime ();
181 delete_history.begin (tr);243 delete_history.begin (tr);
182 Gtk.RecentManager recent = new Gtk.RecentManager ().get_default ();244
183 try {245 // Deletes all recent files
184 recent.purge_items ();246 if (recent.size > 0) {
185 } catch (Error err) {247 try {
186 critical (err.message);248 recent.purge_items ();
249 } catch (Error err) {
250 critical (err.message);
251 }
187 }252 }
188 }253 }
189 remove_popover.hide ();254 remove_popover.hide ();

Subscribers

People subscribed via source and target branches