Code review comment for lp:~f.zweig/ubuntu/maverick/guake/guake-fix-650928

Revision history for this message
Stefano Rivera (stefanor) wrote :

-guake (0.4.2-2ubuntu1) maverick; urgency=low
+guake (0.4.2-1) unstable; urgency=low

Err, why?

At what point did this change from a string to an int? Well, my real question is: Will some users still have strings, do you have to touch your proxy settings to get it to become an int? If so, the Redhat patch is preferable.

Also, note that as this is an SRU, it should have an SRU version number, i.e. 0.4.2-2ubuntu1.1 and be aimed at maverick-proposed, not maverick. https://wiki.ubuntu.com/StableReleaseUpdates

We usually prefer to fix bugs like this in the development release before the stable one (so we don't provide an update that causes regressions), but in this case it can probably just be done as an SRU.

review: Needs Fixing

« Back to merge proposal