GTG

Merge lp:~exufer/gtg/bugfix into lp:~gtg/gtg/old-trunk

Proposed by Volodymyr
Status: Merged
Merged at revision: 839
Proposed branch: lp:~exufer/gtg/bugfix
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 36 lines (+10/-0)
3 files modified
AUTHORS (+1/-0)
CHANGELOG (+3/-0)
GTG/taskeditor/editor.py (+6/-0)
To merge this branch: bzr merge lp:~exufer/gtg/bugfix
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Review via email: mp+21808@code.launchpad.net

Description of the change

Fixed bug #532392. This time really, I hope. :)

Now the due date in the task is set to be equal to the start date when it happens that the start date is later than the due date.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good, implements consensus of bug report.
Merged and pushed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AUTHORS'
--- AUTHORS 2010-03-12 10:42:06 +0000
+++ AUTHORS 2010-03-21 16:55:25 +0000
@@ -63,3 +63,4 @@
6363
64For 0.3:64For 0.3:
65----------65----------
66* Volodymyr Floreskul <exufer@gmail.com>
6667
=== modified file 'CHANGELOG'
--- CHANGELOG 2010-02-22 08:21:25 +0000
+++ CHANGELOG 2010-03-21 16:55:25 +0000
@@ -1,3 +1,6 @@
12010-03-01 Getting Things GNOME! 0.3-development
2 * Fixed bug #532392, a start date is later than a due date, by Volodymyr Floreskul
3
12010-03-01 Getting Things GNOME! 0.2.242010-03-01 Getting Things GNOME! 0.2.2
2 * Autostart on login, by Luca Invernizzi5 * Autostart on login, by Luca Invernizzi
3 * Preferences dialog, by Paul Kishimoto6 * Preferences dialog, by Paul Kishimoto
47
=== modified file 'GTG/taskeditor/editor.py'
--- GTG/taskeditor/editor.py 2010-03-12 11:16:15 +0000
+++ GTG/taskeditor/editor.py 2010-03-21 16:55:25 +0000
@@ -384,6 +384,12 @@
384 self.task.set_due_date(datetoset)384 self.task.set_due_date(datetoset)
385 elif data == "closed" :385 elif data == "closed" :
386 self.task.set_closed_date(datetoset)386 self.task.set_closed_date(datetoset)
387 #Set the due date to be equal to the start date
388 # when it happens that the start date is later than the due date
389 start_date = self.task.get_start_date()
390 due_date = self.task.get_due_date()
391 if start_date and (start_date > due_date):
392 self.task.set_due_date(self.task.get_start_date())
387 else :393 else :
388 #We should write in red in the entry if the date is not valid394 #We should write in red in the entry if the date is not valid
389 widget.modify_text(gtk.STATE_NORMAL, gtk.gdk.color_parse("#F00"))395 widget.modify_text(gtk.STATE_NORMAL, gtk.gdk.color_parse("#F00"))

Subscribers

People subscribed via source and target branches

to status/vote changes: