Code review comment for lp:~extra-addons-commiter/openobject-extension/oerp6.1-cleanning

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Nitpicking: a frequency is expressed in Hertz (1/time). A period or rate is expressed in Time. (no need to change in the column name, as it would be cumbersome to migrate, but maybe in the help and displayed strings)

You should add a comment next to EXT_CRON_MINIMUM_FREQUENCY = 10 telling what the unit for this constant is.

line 95: are you sure you want to use <= to trigger the error ? having to specify at least 11 sounds a bit strange.

line 96: s/must be upper/must be greater than/

line 113: no space before ':' in English

line 114: no space before '!' in English (happens in other places too, esp. line 3773 and following in "Error !")

line 198 and following: remove space before ':'

line 415: you should probably add something like : if context is None: context = {} before using context.update(). I don't think the framework guarantees that a dict context argument is provided.

line 635: s/Not parent/No parent/

« Back to merge proposal