Merge lp:~evgeni/libappindicator/optional-mono into lp:libappindicator/12.10

Proposed by Evgeni Golov
Status: Merged
Approved by: Charles Kerr
Approved revision: 241
Merged at revision: 242
Proposed branch: lp:~evgeni/libappindicator/optional-mono
Merge into: lp:libappindicator/12.10
Diff against target: 102 lines (+23/-13)
2 files modified
bindings/Makefile.am (+4/-2)
configure.ac (+19/-11)
To merge this branch: bzr merge lp:~evgeni/libappindicator/optional-mono
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+109509@code.launchpad.net

Description of the change

there are archs (mips, mipsel, s390, hurd) which do not support mono,
let's build the mono buildings only when mono is available (and write a notice otherwise).
this allows non-mono apps to use libappindicator on non-mono archs.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Good patch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bindings/Makefile.am'
--- bindings/Makefile.am 2011-02-03 15:22:06 +0000
+++ bindings/Makefile.am 2012-06-10 07:47:19 +0000
@@ -1,10 +1,12 @@
1if USE_GTK31if USE_GTK3
2SUBDIRS = \2SUBDIRS = \
3 mono \
4 vala3 vala
5else4else
6SUBDIRS = \5SUBDIRS = \
7 mono \
8 python \6 python \
9 vala7 vala
10endif8endif
9
10if HAS_MONO
11SUBDIRS += mono
12endif
1113
=== modified file 'configure.ac'
--- configure.ac 2012-04-12 15:13:15 +0000
+++ configure.ac 2012-06-10 07:47:19 +0000
@@ -106,10 +106,11 @@
106106
107MONO_REQUIRED_VERSION=1.0107MONO_REQUIRED_VERSION=1.0
108PKG_CHECK_MODULES(MONO_DEPENDENCY, mono >= $MONO_REQUIRED_VERSION, has_mono=true, has_mono=false)108PKG_CHECK_MODULES(MONO_DEPENDENCY, mono >= $MONO_REQUIRED_VERSION, has_mono=true, has_mono=false)
109AM_CONDITIONAL(HAS_MONO, [test "x$has_mono" = "xtrue"])
109110
110AC_PATH_PROG(AL, al, no)111AC_PATH_PROG(AL, al, no)
111if test "x$AL" = "xno" ; then112if test "x$AL" = "xno" ; then
112 AC_MSG_ERROR([No al tool found. You need to install Mono.])113 AC_MSG_NOTICE([No al tool found. You need to install Mono.])
113fi114fi
114115
115if test "x$has_mono" = "xtrue" ; then116if test "x$has_mono" = "xtrue" ; then
@@ -126,12 +127,12 @@
126fi127fi
127128
128if test "x$CSC" = "xno" ; then129if test "x$CSC" = "xno" ; then
129 AC_MSG_ERROR([No Mono compiler found.])130 AC_MSG_NOTICE([No Mono compiler found.])
130fi131fi
131132
132AC_PATH_PROG(GACUTIL, gacutil, no)133AC_PATH_PROG(GACUTIL, gacutil, no)
133if test "x$GACUTIL" = "xno" ; then134if test "x$GACUTIL" = "xno" ; then
134 AC_MSG_ERROR([No gacutil tool found])135 AC_MSG_NOTICE([No gacutil tool found])
135fi136fi
136137
137AC_SUBST(RUNTIME)138AC_SUBST(RUNTIME)
@@ -143,9 +144,9 @@
143144
144GLIB_SHARP_REQ_VERSION=2.12.1145GLIB_SHARP_REQ_VERSION=2.12.1
145GTK_SHARP_REQ_VERSION=2.12146GTK_SHARP_REQ_VERSION=2.12
146PKG_CHECK_MODULES(GTK_SHARP, gtk-sharp-2.0 >= $GTK_SHARP_REQ_VERSION)147PKG_CHECK_MODULES(GTK_SHARP, gtk-sharp-2.0 >= $GTK_SHARP_REQ_VERSION, has_gtksharp=true, has_gtksharp=false)
147148
148PKG_CHECK_MODULES(GAPI, gapi-2.0 >= $GLIB_SHARP_REQ_VERSION)149PKG_CHECK_MODULES(GAPI, gapi-2.0 >= $GLIB_SHARP_REQ_VERSION, has_gapi=true, has_gapi=false)
149AC_PATH_PROG(GAPI_PARSER, gapi2-parser, no)150AC_PATH_PROG(GAPI_PARSER, gapi2-parser, no)
150AC_SUBST(GAPI_PARSER)151AC_SUBST(GAPI_PARSER)
151AC_PATH_PROG(GAPI_CODEGEN, gapi2-codegen, no)152AC_PATH_PROG(GAPI_CODEGEN, gapi2-codegen, no)
@@ -238,12 +239,6 @@
238src/appindicator-0.1.pc239src/appindicator-0.1.pc
239src/appindicator3-0.1.pc240src/appindicator3-0.1.pc
240bindings/Makefile241bindings/Makefile
241bindings/mono/Makefile
242bindings/mono/appindicator-sharp.dll.config
243bindings/mono/appindicator-sharp-0.1.pc
244bindings/mono/app-indicator.sources.xml
245bindings/mono/examples/Makefile
246bindings/mono/examples/indicator-example
247bindings/python/Makefile242bindings/python/Makefile
248bindings/python/appindicator.override243bindings/python/appindicator.override
249bindings/vala/Makefile244bindings/vala/Makefile
@@ -255,6 +250,18 @@
255docs/reference/version.xml250docs/reference/version.xml
256docs/reference/libappindicator-docs.sgml251docs/reference/libappindicator-docs.sgml
257])252])
253
254if test "x$has_mono" = "xtrue" ; then
255 AC_CONFIG_FILES([
256 bindings/mono/Makefile
257 bindings/mono/appindicator-sharp.dll.config
258 bindings/mono/appindicator-sharp-0.1.pc
259 bindings/mono/app-indicator.sources.xml
260 bindings/mono/examples/Makefile
261 bindings/mono/examples/indicator-example
262 ])
263fi
264
258AC_OUTPUT265AC_OUTPUT
259266
260###########################267###########################
@@ -267,6 +274,7 @@
267274
268 Prefix: $prefix275 Prefix: $prefix
269 GTK+ Version: $with_gtk276 GTK+ Version: $with_gtk
277 Mono: $has_mono
270 Tests: $enable_tests278 Tests: $enable_tests
271 Mono tests: $have_nunit279 Mono tests: $have_nunit
272 gcov: $use_gcov280 gcov: $use_gcov

Subscribers

People subscribed via source and target branches