Merge lp:~evfool/software-properties/lp709079 into lp:software-properties

Proposed by Robert Roth
Status: Merged
Merged at revision: 754
Proposed branch: lp:~evfool/software-properties/lp709079
Merge into: lp:software-properties
Diff against target: 50 lines (+5/-12)
2 files modified
softwareproperties/gtk/SimpleGtkbuilderApp.py (+2/-11)
softwareproperties/gtk/utils.py (+3/-1)
To merge this branch: bzr merge lp:~evfool/software-properties/lp709079
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+108795@code.launchpad.net

Description of the change

Refactored SimpleGtkBuilder __init__ method to use the setup_ui method containing exactly the same code (removes some duplicated code) and replaced print to stderr with debug logging message, fixing bug #709079.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwareproperties/gtk/SimpleGtkbuilderApp.py'
2--- softwareproperties/gtk/SimpleGtkbuilderApp.py 2011-07-25 09:56:30 +0000
3+++ softwareproperties/gtk/SimpleGtkbuilderApp.py 2012-06-05 18:09:17 +0000
4@@ -22,23 +22,14 @@
5 import logging
6 import sys
7 from gi.repository import Gtk
8-
9+from softwareproperties.gtk.utils import setup_ui
10 LOG=logging.getLogger(__name__)
11
12 # based on SimpleGladeApp
13 class SimpleGtkbuilderApp:
14
15 def __init__(self, path, domain):
16- self.builder = Gtk.Builder()
17- self.builder.set_translation_domain(domain)
18- self.builder.add_from_file(path)
19- self.builder.connect_signals(self)
20- for o in self.builder.get_objects():
21- if issubclass(type(o), Gtk.Buildable):
22- name = Gtk.Buildable.get_name(o)
23- setattr(self, name, o)
24- else:
25- logging.debug("can not get name for object '%s'" % o)
26+ setup_ui(self, path, domain)
27
28 def run(self):
29 """
30
31=== modified file 'softwareproperties/gtk/utils.py'
32--- softwareproperties/gtk/utils.py 2011-01-25 17:56:51 +0000
33+++ softwareproperties/gtk/utils.py 2012-06-05 18:09:17 +0000
34@@ -17,8 +17,10 @@
35 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
36
37 from gi.repository import Gtk
38+import logging
39 import os
40 import sys
41+LOG=logging.getLogger(__name__)
42
43 def setup_ui(self, path, domain):
44 # setup ui
45@@ -31,4 +33,4 @@
46 name = Gtk.Buildable.get_name(o)
47 setattr(self, name, o)
48 else:
49- print >> sys.stderr, "WARNING: can not get name for '%s'" % o
50+ logging.debug("can not get name for object '%s'" % o)

Subscribers

People subscribed via source and target branches

to status/vote changes: