Merge lp:~evfool/software-center/specs-update into lp:software-center/5.2

[Robert Roth]

This branch contains the following changes (based on the specification https://wiki.ubuntu.com/SoftwareCenter#Software_item_screen) to the application details view
* Moved the recommended applications section after the package details
* Moved the addon status bar after the addons list
* Aligned the star ratings widget vertically with the titles
* Added some vertical padding before the star ratings widget to look better

[Michael Vogt (mvo)]

Thanks, I merge that into trunk.

review: Approve

[Michael Vogt (mvo)]

This is merged into trunk now.

=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
--- softwarecenter/ui/gtk3/views/appdetailsview.py	2012-05-14 03:16:07 +0000
+++ softwarecenter/ui/gtk3/views/appdetailsview.py	2012-05-17 19:05:21 +0000
@@ -1168,9 +1168,9 @@
         self.review_stats_widget = StarRatingsWidget()
         self.review_stats = Gtk.HBox()
         vb_inner.pack_start(
-            self.review_stats, False, False, 0)
+            self.review_stats, False, False, StockEms.SMALL)
         self.review_stats.pack_start(
-            self.review_stats_widget, False, False, StockEms.SMALL)
+            self.review_stats_widget, False, False, 0)
 
         #~ vb_inner.set_property("can-focus", True)
         self.title.a11y = vb_inner.get_accessible()
@@ -1264,23 +1264,12 @@
         info_vb.pack_start(self.addon_view, False, False, 0)
 
         self.addons_statusbar = self.addons_manager.status_bar
-        self.addon_view.pack_start(self.addons_statusbar, False, False, 0)
+        self.addon_view.pack_end(self.addons_statusbar, False, False, 0)
         self.addon_view.connect('table-built', self._on_addon_table_built)
 
         self.addons_hbar = self._hbars[1]
         info_vb.pack_start(self.addons_hbar, False, False, StockEms.SMALL)
 
-        # recommendations
-        catview = CategoriesViewGtk(
-            self.datadir, None, self.cache, self.db, self.icons, None)
-        self.recommended_for_app_panel = RecommendationsPanelDetails(catview)
-        self.recommended_for_app_panel.connect(
-            "application-activated",
-            self._on_recommended_application_activated)
-        self.recommended_for_app_panel.show_all()
-        self.info_vb.pack_start(self.recommended_for_app_panel, False,
-            False, 0)
-
         # package info
         self.info_keys = []
 
@@ -1309,6 +1298,17 @@
 
         vb.pack_start(self._hbars[2], False, False, 0)
 
+        # recommendations
+        catview = CategoriesViewGtk(
+            self.datadir, None, self.cache, self.db, self.icons, None)
+        self.recommended_for_app_panel = RecommendationsPanelDetails(catview)
+        self.recommended_for_app_panel.connect(
+            "application-activated",
+            self._on_recommended_application_activated)
+        self.recommended_for_app_panel.show_all()
+        self.info_vb.pack_start(self.recommended_for_app_panel, False,
+            False, 0)
+
         # reviews cascade
         self.reviews.connect("new-review", self._on_review_new)
         self.reviews.connect("report-abuse", self._on_review_report_abuse)