Merge lp:~evfool/software-center/gtk3fixes into lp:software-center

Proposed by Robert Roth
Status: Merged
Merged at revision: 2170
Proposed branch: lp:~evfool/software-center/gtk3fixes
Merge into: lp:software-center
Diff against target: 71 lines (+9/-5)
4 files modified
data/ui/gtk3/SoftwareCenter.ui (+0/-1)
softwarecenter/ui/gtk3/app.py (+2/-0)
softwarecenter/ui/gtk3/panes/historypane.py (+3/-1)
softwarecenter/ui/gtk3/views/appdetailsview_gtk.py (+4/-3)
To merge this branch: bzr merge lp:~evfool/software-center/gtk3fixes
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+72588@code.launchpad.net

Description of the change

The branch uses the distro-specific name of the application in the help menu, replaces the Developer website button on the app details page with a developer website label, and shows Today on today's installations/updates/removals in the history pane.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ui/gtk3/SoftwareCenter.ui'
--- data/ui/gtk3/SoftwareCenter.ui 2011-08-18 17:42:33 +0000
+++ data/ui/gtk3/SoftwareCenter.ui 2011-08-23 15:03:57 +0000
@@ -437,7 +437,6 @@
437 <property name="can_focus">False</property>437 <property name="can_focus">False</property>
438 <child>438 <child>
439 <object class="GtkImageMenuItem" id="menuitem_help">439 <object class="GtkImageMenuItem" id="menuitem_help">
440 <property name="label" translatable="yes">Software Center _Help</property>
441 <property name="visible">True</property>440 <property name="visible">True</property>
442 <property name="can_focus">False</property>441 <property name="can_focus">False</property>
443 <property name="use_action_appearance">False</property>442 <property name="use_action_appearance">False</property>
444443
=== modified file 'softwarecenter/ui/gtk3/app.py'
--- softwarecenter/ui/gtk3/app.py 2011-08-19 08:47:58 +0000
+++ softwarecenter/ui/gtk3/app.py 2011-08-23 15:03:57 +0000
@@ -326,6 +326,8 @@
326 Gdk.keyval_from_name("KP_Right"),326 Gdk.keyval_from_name("KP_Right"),
327 Gdk.ModifierType.MOD1_MASK,327 Gdk.ModifierType.MOD1_MASK,
328 Gtk.AccelFlags.VISIBLE)328 Gtk.AccelFlags.VISIBLE)
329 # TRANSLATORS: this is the help menuitem label, e.g. Ubuntu Software Center _Help
330 self.menuitem_help.set_label(_("%s _Help")%self.distro.get_app_name())
329331
330 # specify the smallest allowable window size332 # specify the smallest allowable window size
331 self.window_main.set_default_size(700, 400)333 self.window_main.set_default_size(700, 400)
332334
=== modified file 'softwarecenter/ui/gtk3/panes/historypane.py'
--- softwarecenter/ui/gtk3/panes/historypane.py 2011-08-23 07:38:52 +0000
+++ softwarecenter/ui/gtk3/panes/historypane.py 2011-08-23 15:03:57 +0000
@@ -363,7 +363,9 @@
363 elif isinstance(when, datetime.date):363 elif isinstance(when, datetime.date):
364 today = datetime.date.today()364 today = datetime.date.today()
365 monday = today - datetime.timedelta(days=today.weekday())365 monday = today - datetime.timedelta(days=today.weekday())
366 if when >= monday:366 if when == today:
367 text = _("Today")
368 elif when >= monday:
367 # Current week, display the name of the day369 # Current week, display the name of the day
368 text = when.strftime(_('%A'))370 text = when.strftime(_('%A'))
369 else:371 else:
370372
=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview_gtk.py'
--- softwarecenter/ui/gtk3/views/appdetailsview_gtk.py 2011-08-22 11:56:17 +0000
+++ softwarecenter/ui/gtk3/views/appdetailsview_gtk.py 2011-08-23 15:03:57 +0000
@@ -898,7 +898,7 @@
898 self.addons_statusbar.hide()898 self.addons_statusbar.hide()
899 return899 return
900900
901 def _on_homepage_clicked(self, button):901 def _on_homepage_clicked(self, label, link):
902 import webbrowser902 import webbrowser
903 webbrowser.open_new_tab(self.app_details.website)903 webbrowser.open_new_tab(self.app_details.website)
904 return904 return
@@ -992,8 +992,8 @@
992 self.weblive.client.connect("warning", self.on_weblive_warning)992 self.weblive.client.connect("warning", self.on_weblive_warning)
993993
994 # homepage link button994 # homepage link button
995 self.homepage_btn = Gtk.Button.new_with_label(_('Developer Web Site'))995 self.homepage_btn = Gtk.Label()
996 self.homepage_btn.connect('clicked', self._on_homepage_clicked)996 self.homepage_btn.connect('activate-link', self._on_homepage_clicked)
997997
998 # add the links footer to the description widget998 # add the links footer to the description widget
999 footer_hb = Gtk.HBox(spacing=6)999 footer_hb = Gtk.HBox(spacing=6)
@@ -1154,6 +1154,7 @@
1154 # show or hide the homepage button and set uri if homepage specified1154 # show or hide the homepage button and set uri if homepage specified
1155 if app_details.website:1155 if app_details.website:
1156 self.homepage_btn.show()1156 self.homepage_btn.show()
1157 self.homepage_btn.set_markup("<a href=\"%s\">%s</a>"%(self.app_details.website, _('Developer Web Site')))
1157 self.homepage_btn.set_tooltip_text(app_details.website)1158 self.homepage_btn.set_tooltip_text(app_details.website)
1158 else:1159 else:
1159 self.homepage_btn.hide()1160 self.homepage_btn.hide()