Code review comment for lp:~evfool/midori/lp699970

Revision history for this message
Cris Dywan (kalikiana) wrote :

I like the idea; though I think it definitely needs restricting, unconditional reloading would be very painful.

How about adding this to midori-tab.vala
enum LoadError { NONE, DELAYED, SECURITY, CRASH, NETWORK }
Set it like
midori_tab_set_load_error (MIDORI_TAB (view), MIDORI_LOAD_ERROR_NETWORK);
in webkit_web_view_load_error_cb
and reset it in midori_view_load_committed to NONE

The other suggested values aren't required for this one, I'm mentioning them for completeness if you'd like to add them as well I wouldn't mind, but just NONE and NETWORK would do.

review: Needs Fixing

« Back to merge proposal