Merge lp:~evfool/audience/gtk-3.12 into lp:~audience-members/audience/gtk-3.12

Proposed by Robert Roth
Status: Merged
Approved by: Corentin Noël
Approved revision: 346
Merged at revision: 347
Proposed branch: lp:~evfool/audience/gtk-3.12
Merge into: lp:~audience-members/audience/gtk-3.12
Diff against target: 55 lines (+7/-7)
2 files modified
src/Audience.vala (+3/-3)
src/Widgets/VideoPlayer.vala (+4/-4)
To merge this branch: bzr merge lp:~evfool/audience/gtk-3.12
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+223918@code.launchpad.net

Description of the change

Do not use deprecated stock items.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Audience.vala'
--- src/Audience.vala 2014-06-13 16:12:01 +0000
+++ src/Audience.vala 2014-06-20 13:22:11 +0000
@@ -334,8 +334,8 @@
334 default:334 default:
335 var d = new Gtk.Dialog.with_buttons (_("Open location"),335 var d = new Gtk.Dialog.with_buttons (_("Open location"),
336 this.mainwindow, Gtk.DialogFlags.MODAL,336 this.mainwindow, Gtk.DialogFlags.MODAL,
337 Gtk.Stock.CANCEL, Gtk.ResponseType.CANCEL,337 _("_Cancel"), Gtk.ResponseType.CANCEL,
338 Gtk.Stock.OK, Gtk.ResponseType.OK);338 _("_OK"), Gtk.ResponseType.OK);
339339
340 var grid = new Gtk.Grid ();340 var grid = new Gtk.Grid ();
341 var entry = new Gtk.Entry ();341 var entry = new Gtk.Entry ();
@@ -553,7 +553,7 @@
553 public void run_open (int type) { //0=file, 2=dvd553 public void run_open (int type) { //0=file, 2=dvd
554 if (type == 0) {554 if (type == 0) {
555 var file = new Gtk.FileChooserDialog (_("Open"), mainwindow, Gtk.FileChooserAction.OPEN,555 var file = new Gtk.FileChooserDialog (_("Open"), mainwindow, Gtk.FileChooserAction.OPEN,
556 Gtk.Stock.CANCEL, Gtk.ResponseType.CANCEL, Gtk.Stock.OPEN, Gtk.ResponseType.ACCEPT);556 _("_Cancel"), Gtk.ResponseType.CANCEL, _("_Open"), Gtk.ResponseType.ACCEPT);
557 file.select_multiple = true;557 file.select_multiple = true;
558558
559 var all_files_filter = new Gtk.FileFilter ();559 var all_files_filter = new Gtk.FileFilter ();
560560
=== modified file 'src/Widgets/VideoPlayer.vala'
--- src/Widgets/VideoPlayer.vala 2014-05-02 21:27:42 +0000
+++ src/Widgets/VideoPlayer.vala 2014-06-20 13:22:11 +0000
@@ -326,9 +326,9 @@
326 }326 }
327327
328 void show_error (string? message=null) {328 void show_error (string? message=null) {
329 var dlg = new Gtk.Dialog.with_buttons (_("Error"), null, Gtk.DialogFlags.MODAL, Gtk.Stock.OK, Gtk.ResponseType.OK);329 var dlg = new Gtk.Dialog.with_buttons (_("Error"), null, Gtk.DialogFlags.MODAL, _("_OK"), Gtk.ResponseType.OK);
330 var grid = new Gtk.Grid ();330 var grid = new Gtk.Grid ();
331 var err = new Gtk.Image.from_stock (Gtk.Stock.DIALOG_ERROR, Gtk.IconSize.DIALOG);331 var err = new Gtk.Image.from_icon_name ("dialog-error", Gtk.IconSize.DIALOG);
332 err.margin_right = 12;332 err.margin_right = 12;
333 333
334 var err_label = new Gtk.Label ("");334 var err_label = new Gtk.Label ("");
@@ -351,7 +351,7 @@
351 var detail = Gst.PbUtils.missing_plugin_message_get_description (msg);351 var detail = Gst.PbUtils.missing_plugin_message_get_description (msg);
352 var dlg = new Gtk.Dialog.with_buttons ("Missing plugin", null, Gtk.DialogFlags.MODAL);352 var dlg = new Gtk.Dialog.with_buttons ("Missing plugin", null, Gtk.DialogFlags.MODAL);
353 var grid = new Gtk.Grid ();353 var grid = new Gtk.Grid ();
354 var err = new Gtk.Image.from_stock (Gtk.Stock.DIALOG_ERROR, Gtk.IconSize.DIALOG);354 var err = new Gtk.Image.from_icon_name ("dialog-error", Gtk.IconSize.DIALOG);
355 var phrase = new Gtk.Label (_("Some media files need extra software to be played. Audience can install this software automatically."));355 var phrase = new Gtk.Label (_("Some media files need extra software to be played. Audience can install this software automatically."));
356356
357 err.margin_right = 12;357 err.margin_right = 12;
@@ -411,4 +411,4 @@
411 }411 }
412 }412 }
413 }413 }
414}
415\ No newline at end of file414\ No newline at end of file
415}

Subscribers

People subscribed via source and target branches

to all changes: