Code review comment for lp:~evarlast/juju-quickstart/which-juju

Revision history for this message
Brad Crittenden (bac) wrote :

The branch LGTM Jay. Thanks for getting it done and working with
Francesco to improve it.

https://codereview.appspot.com/132770043/diff/100001/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/132770043/diff/100001/quickstart/app.py#newcode550
quickstart/app.py:550: The env_type argument is the current environment
type.
I haven't looked at the quickstart code in a while so I didn't
immediately know what an 'env_type' was but could guess it meant
"environment type". Then I was in the unhappy place of not knowing what
an environment type was.

Perhaps you could augment this comment with "e.g. local, ec2, azure".

https://codereview.appspot.com/132770043/

« Back to merge proposal