Code review comment for lp:~evarlast/juju-quickstart/which-juju

Revision history for this message
Jay R. Wren (evarlast) wrote :

Please take a look.

https://codereview.appspot.com/132770043/diff/80001/quickstart/tests/test_platform_support.py
File quickstart/tests/test_platform_support.py (right):

https://codereview.appspot.com/132770043/diff/80001/quickstart/tests/test_platform_support.py#newcode170
quickstart/tests/test_platform_support.py:170: class
TestGetJujuCommand(unittest.TestCase):
On 2014/08/25 14:37:39, frankban wrote:
> What do you think about changing from expected/actual to
> expected_command/assertTrue also in the first and third tests here?
> I read the second one way better.

Done.

https://codereview.appspot.com/132770043/diff/80001/quickstart/tests/test_platform_support.py#newcode178
quickstart/tests/test_platform_support.py:178: def
test_getenv_fails_when_ignore_env_var(self):
On 2014/08/25 14:37:38, frankban wrote:
> The test name here seems to no longer describe the goal.

Done.

https://codereview.appspot.com/132770043/

« Back to merge proposal