Juju Charms Collection
apache2 package

Code review comment for lp:~evarlast/charms/trusty/apache2/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Andrew McLeod (admcleod) wrote :

Hi Jay,

In order to confirm your changes are fully functional, I've attempted to run bundletester (bundletester -e $AWS -l DEBUG -vF) on this.

It appears that there are initial failures related to apt-source, but because of the 'F' I see that there are also older issues related to assert_called_once (see: https://bugs.launchpad.net/charms/+source/apache2/+bug/1511474)

Unfortunately because tests are failing (as noted by the automated testing also) I can't approve this - however, perhaps they're passing for you? If so can you tell me more about your environment so I can try to replicate it - I'm using trusty.

Thanks!
Andrew

review: Needs Fixing

« Back to merge proposal