Merge lp:~evarlast/charms/precise/juju-gui/hacking-note into lp:~juju-gui/charms/trusty/juju-gui/trunk

[Jay R. Wren]

update HACKING.md

note that ppa stable is required
  New devs might assume that ppa:juju/devel subsumes ppa:juju/stable.
  Note that it does not.

add Proposing Branches section to document use of lbox

https://codereview.appspot.com/107690044/

[Jay R. Wren (evarlast)]

Reviewers: mp+226194_code.launchpad.net,

Message:
Please take a look.

Description:
update HACKING.md

note that ppa stable is required
   New devs might assume that ppa:juju/devel subsumes ppa:juju/stable.
   Note that it does not.

add Proposing Branches section to document use of lbox

https://code.launchpad.net/~evarlast/charms/precise/juju-gui/hacking-note/+merge/226194

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/107690044/

Affected files (+29, -1 lines):
   M HACKING.md
   A [revision details]
   M hooks/utils.py

Index: HACKING.md
=== modified file 'HACKING.md'
--- HACKING.md 2014-04-22 10:28:39 +0000
+++ HACKING.md 2014-07-09 18:38:56 +0000
@@ -42,6 +42,8 @@
      sudo apt-get update
      sudo apt-get install charm-tools

+Note that **ppa:juju/devel does NOT subsume ppa:juju/stable. You must add
ppa:juju/stable**.
+
  Before being able to run the suite, test requirements need to be installed
  running the command:

@@ -257,3 +259,27 @@
  following in the Juju GUI machine:

      service guiserver restart
+
+## Proposing Branches ##
+
+We use [lbox](http://launchpad.net/lbox) to propose branches for review
+and submit them to the trunk. Gustavo Niemeyer has
+[a helpful
blogpost](http://blog.labix.org/2011/11/17/launchpad-rietveld-happycodereviews)
+about this tool.
+
+To install lbox make sure you GOPATH is set and run go get
launchpad.net/lbox.
+
+On first run lbox will attempt to launch sensible-browser or failing that
+$BROWSER to obtain oauth credentials to launchpad. This is stored to
+$HOME/.lpad_oath . You may want to chmod 0600 this file if your umask is
more
+open by default.
+
+Next, to post to https://codereview.appspot.com, your google credentials
are
+requested. This uses https://www.google.com/accounts/ClientLogin (You don't
+have to worry about plain text password over internet.) Cookies and oauth
+credentials get stored at $HOME/.goetveld_codereview.appspot.com . This
time
+the file should default to mode 0600, but you can double check for your own
+security sanity.
+
+To post a review, bzr push to
lp:~YOURNAME/charms/trusty/juju-gui/BRANCHNAME and
+run lbox propose.

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: hooks/utils.py
=== modified file 'hooks/utils.py'
--- hooks/utils.py 2014-04-15 09:38:31 +0000
+++ hooks/utils.py 2014-07-08 15:52:13 +0000
@@ -747,7 +747,7 @@
              'openssl', 'req', '-new', '-newkey', 'rsa:4096',
              '-days', '365', '-nodes', '-x509', '-subj',
              # These are arbitrary test values for the certificate.
- '/C=GB/ST=Juju/L=GUI/O=Ubuntu/CN=juju.ubuntu.com',
+ '/C=GB/ST=Juju/L=GUI/O=Ubuntu/CN=your-jujugui.local',
              '-keyout', key_path, '-out', crt_path))
      # Generate the pem file.
      pem_path = os.path.join(ssl_cert_path, JUJU_PEM)

[Richard Harding (rharding)]

LGTM thanks for this. Feel free to submit it.

https://codereview.appspot.com/107690044/

[Jay R. Wren (evarlast)]

*** Submitted:

update HACKING.md

note that ppa stable is required
   New devs might assume that ppa:juju/devel subsumes ppa:juju/stable.
   Note that it does not.

add Proposing Branches section to document use of lbox

R=rharding
CC=
https://codereview.appspot.com/107690044

https://codereview.appspot.com/107690044/

=== modified file 'HACKING.md'
--- HACKING.md	2014-04-22 10:28:39 +0000
+++ HACKING.md	2014-07-09 18:43:08 +0000
@@ -42,6 +42,8 @@
     sudo apt-get update
     sudo apt-get install charm-tools
 
+Note that **ppa:juju/devel does NOT subsume ppa:juju/stable. You must add ppa:juju/stable**.
+
 Before being able to run the suite, test requirements need to be installed
 running the command:
 
@@ -257,3 +259,27 @@
 following in the Juju GUI machine:
 
     service guiserver restart
+
+## Proposing Branches ##
+
+We use [lbox](http://launchpad.net/lbox) to propose branches for review
+and submit them to the trunk. Gustavo Niemeyer has
+[a helpful blogpost](http://blog.labix.org/2011/11/17/launchpad-rietveld-happycodereviews)
+about this tool.
+
+To install lbox make sure you GOPATH is set and run go get launchpad.net/lbox.
+
+On first run lbox will attempt to launch sensible-browser or failing that
+$BROWSER to obtain oauth credentials to launchpad.  This is stored to
+$HOME/.lpad_oath .  You may want to chmod 0600 this file if your umask is more
+open by default.
+
+Next, to post to https://codereview.appspot.com, your google credentials are
+requested. This uses https://www.google.com/accounts/ClientLogin (You don't
+have to worry about plain text password over internet.) Cookies and oauth
+credentials get stored at $HOME/.goetveld_codereview.appspot.com . This time
+the file should default to mode 0600, but you can double check for your own
+security sanity.
+
+To post a review, bzr push to lp:~YOURNAME/charms/trusty/juju-gui/BRANCHNAME and
+run lbox propose. 

=== modified file 'hooks/utils.py'
--- hooks/utils.py	2014-04-15 09:38:31 +0000
+++ hooks/utils.py	2014-07-09 18:43:08 +0000
@@ -747,7 +747,7 @@
             'openssl', 'req', '-new', '-newkey', 'rsa:4096',
             '-days', '365', '-nodes', '-x509', '-subj',
             # These are arbitrary test values for the certificate.
-            '/C=GB/ST=Juju/L=GUI/O=Ubuntu/CN=juju.ubuntu.com',
+            '/C=GB/ST=Juju/L=GUI/O=Ubuntu/CN=your-jujugui.local',
             '-keyout', key_path, '-out', crt_path))
     # Generate the pem file.
     pem_path = os.path.join(ssl_cert_path, JUJU_PEM)