Merge lp:~evarlast/charms/precise/hive/encoding into lp:charms/hive

[Jay R. Wren]

relation-set encoding=latin1 on relation joined to work with mysql charm which uses this to create database with this encoding.

Is a no-op if a different mysql charm is used.

[Chris Glass (tribaal)]

Will that work with the current trunk mysql charm (that does *not* have this branch merged in https://code.launchpad.net/~evarlast/charms/precise/mysql/encoding)?

review: Needs Information

[Jay R. Wren (evarlast)]

It will work as a no-op. Relation interfaces are convention based. The mysql charm will never call relation-get, and so this hive charm will continue to function as it has been with the current mysql charm.

[Chris Glass (tribaal)]

You're correct, looks good! +1

review: Approve

[amir sanjar (asanjar)]

why not port the changes to hive2 with hive-server2 charm? Hive 0.8.2 is absolute

[amir sanjar (asanjar)]

please look at latest hive charms (hortonworks hive 0.13.0)
lp:~asanjar/charms/trusty/hdp-hive/trunk
Apache Hive 0.11.3
https://code.launchpad.net/~asanjar/charms/precise/hive2/trunk

review: Needs Information

[Jay R. Wren (evarlast)]

This change is only because of this bug: https://bugs.launchpad.net/charms/+source/mysql/+bug/965094

If this charm is obsolete, is there a way to mark it as such?

Unmerged revisions

8. By Jay R. Wren on 2014-07-11

relation-set encoding=latin1 on joined

requires updated mysql charm to work, doesn't break anything (noop)
with older mysql

=== modified file 'hooks/hive-common'
--- hooks/hive-common	2014-01-06 20:10:56 +0000
+++ hooks/hive-common	2014-07-11 21:14:50 +0000
@@ -302,6 +302,10 @@
             install_packages $role
         fi
         ;;
+    db-relation-joined)
+        relation-set encoding=latin1
+        juju-log "db-relation-joined set encoding=latin1"
+        ;;
     db-relation-changed)
         database=`relation-get database`
         if [ -z "$database" ]