Code review comment for ~evancaville/ubuntu-cve-tracker:oval/fix-kernel-pkg-ids

Revision history for this message
Eduardo Barretto (ebarretto) wrote :

a few notes:
1. It seems both ids we mentioned are not showing up anymore in current oval. Can you find any other case like those?
2. I think the proposed PR is actually creating a big amount of data, that all points to the same variable id.
if you diff a current oval with an oval generated with your patch, you will see that previous entries that all had the same criterion id because they all had the same status, now they each have their own ids, which create more tests with different ids, that creates more objects with different ids that at the end point to all the same variable. We should avoid it, as we try to re-use ids where possible to avoid increasing the oval file size.

review: Needs Fixing

« Back to merge proposal