Code review comment for lp:~ev/ubuntu-ci-services-itself/restish-swift-deployment

Revision history for this message
Evan (ev) wrote :

On 27 January 2014 19:28, Andy Doan <email address hidden> wrote:
> 2) Are you sure code like:
> code_runner = config['user_code_runner']
>
> is safe when no value is provided and default is intended? When I've done this in the past, there is no dictionary item for elements that aren't specified explicitly. so i've always had to do: config.get('user_code_runner', 'restish'). Seems odd/annoying juju wouldn't do that for me, so maybe you know a trick

  user_code_runner:
    default: "restish"
    type: string
    description: The user that runs the code

So it's guaranteed to at least set to 'restish'.

« Back to merge proposal