Code review comment for lp:~ev/apport/handle-thread-crashes

Revision history for this message
Martin Pitt (pitti) wrote :

> a dying PID should be gone by the time apport-{gtk,kde} is run.

This is correct. The kernel core pipeline handler relinquishes stdin as soon as possible, i. e. stdin will be closed (and thus the process will die) even before /usr/share/apport/apport finishes.

Thanks for fixing this, this looks great!

When merging, please remember to add a NEWS entry.

review: Approve

« Back to merge proposal