Code review comment for lp:~ev/apport/disable-core-removal

Martin Pitt (pitti) wrote :

I applied this to the data center retracer:

--- apport/crashdb_impl/launchpad.py 2011-11-16 14:29:24 +0000
+++ apport/crashdb_impl/launchpad.py 2011-11-16 14:29:57 +0000
@@ -636,7 +636,7 @@
                     return

             for a in bug.attachments:
- if a.title in ('CoreDump.gz', 'Stacktrace.txt',
+ if a.title in ('CoreDump.gz',
                     'ThreadStacktrace.txt', 'Dependencies.txt', 'ProcMaps.txt',
                     'ProcStatus.txt', 'Registers.txt', 'Disassembly.txt'):
                     try:

I. e. we'll retain the original Stacktrace.txt as it was produced on the client machines. This will give me the sample data for checking the "client side duplicate signature" idea we discussed. Is this also enough for you?

« Back to merge proposal