Code review comment for ~eugene2021/checkbox-support:pulseaudio

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

That's an impressive work, thanks a lot. Digging into this crazy pyparsing code is not easy.
Parsing pactl output is of course not recommended but there was no better way when we wrote that script and indeed it requires such update for every major release of Ubuntu or PA.
Let's hope pipewire will be easier to handle from a test point of view.

Thanks for the tests and data from your p16 gen!

review: Approve

« Back to merge proposal