Code review comment for lp:~etherpulse/podbird/duplicated_downloads

Revision history for this message
Eran Uzan (etherpulse) wrote :

Hey :)

Exactly, I know the timer is ugly but for some reason all the onCompleted events happen before the downloads list is populated so the downloads list is empty when we add episodes and theres nothing to compare against.
I couldn't find any way around it (checked a lots of onCompleted and other single shot events :/ )
I think I can decrease the timer delay to even 1 millisecond and it will still work my guess it`s some kind of single UI thread issue.

And yeah episode will make more sense i`ll change it.. thanks :)

« Back to merge proposal