Code review comment for lp:~etherpulse/podbird/download_wifi

Revision history for this message
Eran Uzan (etherpulse) wrote :

Hey , Sorry to hear about your loss I hope the laptop had a fulfilling life of development and and creation ;)
I hope it won't be too much of an hassle....

About the negative logic it bothered me too but I kept it this way to support legacy code and to prevent unintended behaviour by other developers, As calling the function without the mobileDl argument will do the same thing as before I added the argument (as "!undefined" will be evaluated to "true").

I would suggest changing the name of the argument to disableMobileDl which then will make sense with the logic it self.

But I can change it if you want...

Hope your new laptop will serve you well,

« Back to merge proposal