Code review comment for lp:~ethan.chang/savilerow/add-welcome-background

Revision history for this message
Chris Wayne (cwayne) wrote :

Hm, I get failures when I test this:

ERROR: custom.api.test_custom_upstartjobs.CustomjobsVerificationTests.test_custom_upstartjobs_running_process
----------------------------------------------------------------------
Empty attachments:
/var/log/syslog

Traceback (most recent call last):
File "/home/phablet/autopilot/custom/api/test_custom_upstartjobs.py", line 37, in test_custom_upstartjobs_running_process
proc_info = ' '.join(proc.cmdline)
TypeError: can only join an iterable
======================================================================
FAIL: custom.api.test_custom_upstartjobs.CustomjobsVerificationTests.test_custom_upstartjobs_directory_exists
----------------------------------------------------------------------
Empty attachments:
/var/log/syslog

Traceback (most recent call last):
File "/home/phablet/autopilot/custom/api/test_custom_upstartjobs.py", line 27, in test_custom_upstartjobs_directory_exists
self.assertTrue(os.path.isfile(os.path.join(path, job)))
File "/usr/lib/python3.4/unittest/case.py", line 654, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true

Ran 20 tests in 1.185s
FAILED (failures=3)

review: Needs Fixing

« Back to merge proposal