Merge ~esunar/charm-graylog:functional-test-fix into charm-graylog:master

Proposed by Erhan Sunar
Status: Merged
Approved by: Eric Chen
Approved revision: 63091e8ef905fb212db507166a6b29a1068f4462
Merged at revision: a8019a9c3ab861f99a4d28be8c9b7d34539e35b2
Proposed branch: ~esunar/charm-graylog:functional-test-fix
Merge into: charm-graylog:master
Diff against target: 43 lines (+8/-3)
3 files modified
Makefile (+1/-1)
charmcraft.yaml (+3/-1)
src/reactive/graylog.py (+4/-1)
Reviewer Review Type Date Requested Status
Eric Chen Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
Review via email: mp+430948@code.launchpad.net

Commit message

Fix functional tests failing in serverstack

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Eric Chen (eric-chen) wrote :

small change , LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision a8019a9c3ab861f99a4d28be8c9b7d34539e35b2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Makefile b/Makefile
index eb7767a..42c8033 100644
--- a/Makefile
+++ b/Makefile
@@ -81,7 +81,7 @@ unittests:
8181
82functional: build82functional: build
83 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"83 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"
84 @cd src && CHARM_BUILD_DIR=${CHARM_BUILD_DIR} CHARM_LOCATION=${PROJECTPATH} tox -e func84 @cd src && ZAZA_FEATURE_BUG472=1 CHARM_BUILD_DIR=${CHARM_BUILD_DIR} CHARM_LOCATION=${PROJECTPATH} tox -e func
8585
86functional-extra: build86functional-extra: build
87 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"87 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"
diff --git a/charmcraft.yaml b/charmcraft.yaml
index d64e474..9aa96d7 100644
--- a/charmcraft.yaml
+++ b/charmcraft.yaml
@@ -4,7 +4,9 @@ parts:
4 source: src4 source: src
5 plugin: reactive5 plugin: reactive
6 build-snaps: 6 build-snaps:
7 - charm7 # if it is build with charm/3.x it cannot be installed on bionic
8 # Error: pip requires Python '>=3.7' but the running Python is 3.6.9
9 - charm/2.x/stable
8bases:10bases:
9 - build-on:11 - build-on:
10 - name: ubuntu12 - name: ubuntu
diff --git a/src/reactive/graylog.py b/src/reactive/graylog.py
index 2fb7469..b6f4313 100644
--- a/src/reactive/graylog.py
+++ b/src/reactive/graylog.py
@@ -1360,7 +1360,10 @@ def tls_request_certificate(tls):
1360 set_conf("web_tls_cert_file", CERT_PATH)1360 set_conf("web_tls_cert_file", CERT_PATH)
1361 set_conf("web_tls_key_file", CERT_KEY_PATH)1361 set_conf("web_tls_key_file", CERT_KEY_PATH)
13621362
1363 set_conf("http_publish_uri", "https://0.0.0.0:{}/".format(get_api_port()))1363 set_conf(
1364 "http_publish_uri",
1365 validate_api_uri("https://0.0.0.0:{}/".format(get_api_port())),
1366 )
1364 set_state("graylog.certificates.configured")1367 set_state("graylog.certificates.configured")
1365 remove_state("graylog.initial_certs_received")1368 remove_state("graylog.initial_certs_received")
13661369

Subscribers

People subscribed via source and target branches

to all changes: