Merge lp:~ericsnowcurrently/landscape-client/fix-1681947-script-shbang into lp:~landscape/landscape-client/trunk

Proposed by Eric Snow
Status: Merged
Approved by: Eric Snow
Approved revision: 1015
Merged at revision: 1016
Proposed branch: lp:~ericsnowcurrently/landscape-client/fix-1681947-script-shbang
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 49 lines (+18/-9)
1 file modified
setup.py (+18/-9)
To merge this branch: bzr merge lp:~ericsnowcurrently/landscape-client/fix-1681947-script-shbang
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Francis Ginther (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+322406@code.launchpad.net

Commit message

Only build the scripts under Python 3.

(fixes lp:1681947)

Description of the change

Only build the scripts under Python 3.

(fixes lp:1681947)

Testing instructions:

make package
head debian/tmp/usr/bin/landscape-client # shbang will be python3

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make ci-check
Result: Success
Revno: 1015
Branch: lp:~ericsnowcurrently/landscape-client/fix-1681947-script-shbang
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3872/

review: Approve (test results)
Revision history for this message
Francis Ginther (fginther) wrote :

Yep, it works.

review: Approve
Revision history for this message
Simon Poirier (simpoir) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2017-04-06 18:50:19 +0000
+++ setup.py 2017-04-11 21:35:23 +0000
@@ -1,12 +1,29 @@
1#!/usr/bin/python1#!/usr/bin/python
22
3from distutils.core import setup3from distutils.core import setup
4import sys
45
5from landscape import UPSTREAM_VERSION6from landscape import UPSTREAM_VERSION
67
7from DistUtilsExtra.command import build_extra8from DistUtilsExtra.command import build_extra
8from DistUtilsExtra.auto import clean_build_tree9from DistUtilsExtra.auto import clean_build_tree
910
11
12SCRIPTS = []
13if sys.version_info[0] == 3:
14 SCRIPTS = [
15 "scripts/landscape-client",
16 "scripts/landscape-config",
17 "scripts/landscape-broker",
18 "scripts/landscape-manager",
19 "scripts/landscape-monitor",
20 "scripts/landscape-package-changer",
21 "scripts/landscape-package-reporter",
22 "scripts/landscape-release-upgrader",
23 "scripts/landscape-sysinfo",
24 ]
25
26
10setup(name="Landscape Client",27setup(name="Landscape Client",
11 version=UPSTREAM_VERSION,28 version=UPSTREAM_VERSION,
12 description="Landscape Client",29 description="Landscape Client",
@@ -23,14 +40,6 @@
23 "landscape.upgraders",40 "landscape.upgraders",
24 "landscape.user",41 "landscape.user",
25 "landscape.lib"],42 "landscape.lib"],
26 scripts=["scripts/landscape-client",43 scripts=SCRIPTS,
27 "scripts/landscape-config",
28 "scripts/landscape-broker",
29 "scripts/landscape-manager",
30 "scripts/landscape-monitor",
31 "scripts/landscape-package-changer",
32 "scripts/landscape-package-reporter",
33 "scripts/landscape-release-upgrader",
34 "scripts/landscape-sysinfo"],
35 cmdclass={"build": build_extra.build_extra,44 cmdclass={"build": build_extra.build_extra,
36 "clean": clean_build_tree})45 "clean": clean_build_tree})

Subscribers

People subscribed via source and target branches

to all changes: