Code review comment for lp:~ericsnowcurrently/landscape-bundles/release-17.03

Revision history for this message
Alberto Donato (ack) wrote :

> > I wonder if we shouldn't update the charm instead, and leave the "source"
> > option to the default.
>
> tl;dr That's fine with me.
>
> My only concern would be how we can test the bundle properly before the charm
> gets pushed to the stable channel. AFAIU, the bundle would use the charm from
> the stable channel. Since the charm really can't be tested functionally on
> its own (currently), that means we'd have to release the charm to the stable
> channel before we could test the bundle (and the charm). That said, if
> anything functional changes in the charm we have the same problem, since we'd
> want to test the new charm (via the bundle).

Can't you reference the new revision even if it's published only to the edge channel?

>
> So ultimately I don't think it's a problem to rely on the charm defaults in
> the bundle. The testing story for the charm is already a bit muddled.
> However, if the functional testing story were a bit cleaner then I'd be a bit
> happier about it. :) That could involve better functional testing in the
> charm repo or a way to easily test the bundle against a non-stable charm (or
> even a completely unreleased local dev one). That isn't something we need to
> worry about here though, particularly with something as innocuous as a version
> bump. :)
>
> Long story short: I'll go ahead and drop the version from the bundle.

« Back to merge proposal