Code review comment for lp:~ericsnowcurrently/fake-juju/python-lib-init
Revision history for this message
| Eric Snow (ericsnowcurrently) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> I'll probably need a bit of guidance on intent here.
The intent is to pull the fake-juju bits out of txjuju.testing and into a more useful fakejuju library here.
> # seems to pull in fakejuju/
> cd python; python setup.py build
>
>
> although python setup.py test chokes trying to find a distribution of txjuju,
> how will we be pulling txjuju dependencies?
"python setup.py test"? Does that come for free? There aren't any tests in this patch. You are correct that setup.py won't work as-is. I'm okay with that. :) As long as the deb package works we're fine. The setup.py is mostly informational and useful for building the initial deb packaging code.