Code review comment for lp:~ericsnowcurrently/fake-juju/makefile-tweaks

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

@eric: hmm, I didn't dig but my impression is that "$(JUJU_VERSION)/$(JUJU_VERSION)" is just an internal naming detail. I believe you could name it $(VERSION)/$(VERSION) and set VERSION as appropriate and have it all working as described (i.e. single-version would be a particular case of multi-version, not a case on its own). Anyway, it's a minor detail as long as it works and you're happy enough with it (exp. from a code maintenance point of view), so +1.

review: Approve

« Back to merge proposal