Code review comment for lp:~ericsnowcurrently/fake-juju/makefile-tweaks

Revision history for this message
Chad Smith (chad.smith) wrote :

I like the changes as-is as it feels like a slight improvement, we can tweak as we need to.
The looping construct over "all" targets seems to exit too quickly (@1.24.7) if nothing is needed for that target.

If I run initially make all targets, make changes to 2.0.X, the subsequent make attempt will exit early upon first noop success without trying to build 1.25 or 2.0 targets

make: '1.24.7/1.24.7' is up to date.

review: Approve

« Back to merge proposal