Merge lp:~ericsnowcurrently/fake-juju/fix-makefile-python-path into lp:~landscape/fake-juju/trunk-old

[Eric Snow]

Set PYTHONPATH properly when installing python-fakejuju using setuptools.

Testing instructions:

On Yakkety (see https://code.launchpad.net/~landscape/+recipe/fake-juju-daily),
run "make py-install".

[🤖 Landscape Builder (landscape-builder)]

review: Abstain (executing tests)

[🤖 Landscape Builder (landscape-builder)]

Command: make ci-test
Result: Success
Revno: 50
Branch: lp:~ericsnowcurrently/fake-juju/fix-makefile-python-path
Jenkins: https://ci.lscape.net/job/latch-test-xenial/966/

review: Approve (test results)

[Chad Smith (chad.smith)]

I was able to see "dpkg-buildpackage -b" fail prior to this branch on the py-install target. And after merging this branch dpkg-buildpackage -b succeeds.

As per your test instructions, I also hit the same issue Francis reported,

I can't make py-install target on fresh yakkety or xenial systems.
cd python; python setup.py test also fails with the same traceback.

pip can't find "yaml" requirement for some reason.

running test
Searching for yaml
Reading https://pypi.python.org/simple/yaml/
No local packages or working download links found for yaml
error: Could not find suitable distribution for Requirement.parse('yaml')

[Chad Smith (chad.smith)]

Actually dpkg-buildpackage -b failed both before and after this branch.
I'm not sure how this works. Currently.

review: Needs Information

[Francis Ginther (fginther)]

As mentioned on IRC, I'm getting errors when trying to build this in a clean yakkety lxc:

No local packages or working download links found for yaml
error: Could not find suitable distribution for Requirement.parse('yaml')

I'm also trying to build a package with sbuild, but so far am hitting dependency issues unrelated to this change. Will keep trying.

review: Needs Fixing

Unmerged revisions

=== modified file 'Makefile'
--- Makefile	2016-11-03 16:56:10 +0000
+++ Makefile	2016-11-15 17:59:27 +0000
@@ -149,7 +149,7 @@
 	if [ ! "$(SKIP_PYTHON_LIB)" ]; then \
 		mkdir -p $(PYTHON_INSTALLDIR); \
 		cd python; \
-		$(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \
+		PYTHONPATH=$(PYTHON_INSTALLDIR):$$PYTHONPATH $(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \
 	fi
 
 .PHONY: py-install-dev