Code review comment for lp:~epics-core/epics-gateway/dbe_props

Revision history for this message
Ralph Lange (ralph-lange) wrote :

Thanks for the hint with the private streams - I had to 'reset' my terminal countless times, and wondered what to do about it.

The tests were originally intended to be run on the pyTestsApp directory (note that the runTests.py script takes arguments and thus depends on the arg parser, needed EPICS_HOST_ARCH to be set and was making a bunch of assumptions.

For the time being, I left the ability to run from above the O.<T_A> directory (because it is very handy when developing), and distinguish two cases:
1. running from O.<T_A>, as part of an EPICS build. TOP and T_A are set and being used. If '-tap' is found on the command line (set by the perl wrapper), TAP output is being generated on stdout.
2. running manually from pyTestsApp. TOP defaults to '..', and EPICS_HOST_ARCH must be set.

I should probably remove the command line args to runTests.py and pass the verbosity in the environment. Then a manual run can use one of the standard test runners (preferably nosetests), which automagically finds all test classes and allows selecting the tests to be run.

On a related issue: I plan to add proper support for standard python unit tests using nosetests to EPICS Base. The perl wrapper to run a python script is very awkward.

Stay around for an update of this branch next week.

« Back to merge proposal