Code review comment for lp:~epics-core/epics-base/rsrvbindiface

Revision history for this message
Andrew Johnson (anj) wrote :

Ok; the changes are mostly in rsrv/caservertask.c, but I also added more interest-level conditionals to dbChannelShow() and modified printf() strings in all the std/filters channel_report() methods and in libCom's bucketShow(). I will commit and make the changes on the Wiki page to match.

I did notice that casr() no longer prints a log_one_client() report for the UDP (i.e. name-server) clients. There used to be only one such client thread, but now the number can vary, with one or two threads for each interface. I had removed the UDP reporting code from the log_one_client() routine since it was no longer being used, but I just put it back in case we want to add these threads back into the report. I think I know how to do that if it's wanted.

How are the multicast monitors supposed to work? There isn't a separate thread started for them, the code just joins every primary UDP socket to the multicast group(s) configured. Isn't that going to cause multiple search replies from any IOC that has two interfaces say if both receive a copy of the same multicast search request? We might need a way to configure which multicast addresses get joined to which interfaces if this starts to be used much.

« Back to merge proposal