Code review comment for lp:~epics-core/epics-base/rebased-atomics

Revision history for this message
Andrew Johnson (anj) wrote :

Thanks Jeff, all tests now pass on Solaris and Darwin. I committed a couple of changes to the osi/os/vxWorks directory this morning to clean up compiler warnings on vxWorks 6.8.

One thing I want to point out so everyone is aware of this: By using C++ namespaces we are no longer compatible with the vxWorks 5.4.2 compiler:
  ../../../src/libCom/osi/epicsAtomic.h:108: sorry, not implemented: namespace
  make[3]: *** [epicsAtomicOSD.o] Error 1
I'm not objecting to this at all, just making the fact clear for the record, so the other core developers are all aware that we've taken the step to drop vxWorks 5.4 in Base 3.15. I have committed a note of the new requirement for at least vxWorks 5.5.x to the README.html file.

I would also like to see some documentation on the Atomics API in lp:epics-appdev — the more stuff we add to Base without documenting it at the time, the more work we'll have to do at release-time (or which may never get done). I don't mind converting someone else's words into LaTeX format if you're too busy, but I have no desire to write all the documentation updates myself. I am however currently working on the documentation for some of the other OSI changes which have already been merged, such as the compiler-specific and epicsEvent branches.

I won't hold up this merge waiting for documentation, but that might start to happen in the future if the AppDevGuide gets too far behind the code.

- Andrew

review: Approve

« Back to merge proposal