Code review comment for lp:~epics-core/epics-base/pcas-fake-dynamic

Revision history for this message
Bruce Hill (bhill) wrote :

I don't understand why you guys pushed this through so quickly. As near as I can tell it doesn't accomplish anything. True, pcas now can claim to support CA 4.13 during connection so the client can request zero elements and think they're getting dynamic arrays, but it's still sending the full array.

Please note that this is not the same as the pcas-variable-length-arrays proposal which does support variable sized arrays w/ my patch.

I"m also concerned that this could result in clients compiled w/ CA 4.13 that request zero elements but always copy the full array from a gdd that wouldn't be zero padded if the CA 4.13 compliant PCAS server actually sent the dynamic size.

On 2nd thought, since this change steps on the m_count field in the msg, it would probably keep that app from benefitting when the PCAS server does send the dynamic size as it would always request the full array.

Please reconsider merging this into base.

« Back to merge proposal